Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Greek font table and GR translation #1121

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Add Greek font table and GR translation #1121

merged 5 commits into from
Nov 24, 2021

Conversation

Devnol
Copy link
Contributor

@Devnol Devnol commented Nov 20, 2021

No description provided.

@Devnol
Add Greek font table and GR translation
63cf8aa 
Signed-off-by: Devnol <pgkoutsoumanis@gmail.com>
@Devnol Devnol changed the title Add Greek font table and GR translation Signed-off-by: Devnol <pgkoutsoumanis@gmail.com> Add Greek font table and GR translation Nov 20, 2021
@Devnol
Copy link
Contributor Author

Devnol commented Nov 20, 2021

Please do not merge yet as there are some untranslated strings for whose I do not have context yet, waiting for the build output to see them.

alvinhochun
alvinhochun reviewed Nov 20, 2021
View reviewed changes
Translations/font_tables.py Outdated
@@ -325,6 +325,70 @@ def get_font_map_latin_extended() -> Dict[str, bytes]:
}
return font

#TODO: Add Greek Font
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, chronic brain damage from watching Stanley Kubrick

Translations/font_tables.py Outdated
@@ -749,6 +814,69 @@ def get_small_font_map_latin_extended() -> Dict[str, bytes]:
}
return font

#TODO: Add small greek font
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Translations/font_tables.py Outdated
@@ -772,7 +900,7 @@ def get_small_font_map_cyrillic() -> Dict[str, bytes]:
"А": b"\x7e\x09\x09\x09\x7e\x00",
"Б": b"\x7f\x49\x49\x49\x31\x00",
"В": b"\x7f\x49\x49\x49\x36\x00",
"Г": b"\x7f\x01\x01\x01\x01\x00",
"Г": b"\x7f\x49\x49\x49\x36\x00",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change accidental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I accidentally cmd+v'd instead of cmd+c'ing and it got changed into a B

@alvinhochun
Copy link
Contributor

You should probably add greek to

IronOS/Translations/TranslationEditor.html

Line 308 in bc7d106

<select v-model="fontToAdd">
too

@Devnol
Copy link
Contributor Author

Devnol commented Nov 20, 2021

Will do right now.

@alvinhochun
Copy link
Contributor

Guess this has to wait for @Ralim to approve the workflow. In the meantime you can probably enable GitHub Actions in your fork to test things out now.

@Devnol
Fix issues pointed out by @alvinhochun
e0f9809 
Signed-off-by: Devnol <pgkoutsoumanis@gmail.com>
@Devnol
Copy link
Contributor Author

Devnol commented Nov 20, 2021

I was trying to test the changes locally but make somehow only builds english (see #1120)

@alvinhochun
Copy link
Contributor

Enabling Actions in your fork is simple enough, just visit https://github.com/Devnol/IronOS/actions and click the button.

@Devnol
Copy link
Contributor Author

Devnol commented Nov 20, 2021

ik I did it I just need to commit again to trigger the workflow

@Devnol
Copy link
Contributor Author

Devnol commented Nov 20, 2021

Any idea where the IdleSetString and IdleTipString strings can be found inside the UI?

@alvinhochun
Copy link
Contributor

Any idea where the IdleSetString and IdleTipString strings can be found inside the UI?

Probably in the detailed idle screen (need to enable it in settings), or might've been obsolete after someone revamped the detailed idle screen

@Devnol
Copy link
Contributor Author

Devnol commented Nov 20, 2021

Nope, not there, it was probably removed as I can't find a reference to it in any of the source files, so I'll just leave it as-is

@Devnol
Fix some half height glyphs
ac769c1 
Signed-off-by: Devnol <pgkoutsoumanis@gmail.com>
@Devnol
Make indentation consistent in font_tables.py
9e6783c 
Signed-off-by: Devnol <pgkoutsoumanis@gmail.com>
@Ralim
Copy link
Owner

Ralim commented Nov 22, 2021

Oops sorry for forgetting to enable actions.
Should be good from now one 😓

@Ralim
Copy link
Owner

Ralim commented Nov 22, 2021 •
edited
Loading

Nope, not there, it was probably removed as I can't find a reference to it in any of the source files, so I'll just leave it as-is

I believe they are not used at the moment. I shall try and clean these up later on

Is this done by you btw? (I dont have time to do testing at the moment - away from devices) but happy to merge on your 👍🏼

@Ralim
Copy link
Owner

Ralim commented Nov 23, 2021

heya @Devnol not sure how you feel on this, but maybe we should name the file after the language code for Greek with i think is EL weirdly?

Just thinking if we should head towards these to prevent collisions? Though not super firm on this?

@Devnol
Copy link
Contributor Author

Devnol commented Nov 23, 2021

both EL and GR are valid, usually EL is used for the language and GR for the country because there's also the el_CY locale used in cyprus which just has different measuring units and doesn't apply to IronOS. There shouldn't be any collision but if you wanna be precise EL is the correct code. Fyi it's not weird EL comes from the greek name for the language, which is Ellinika (same root as Hellenic). If you want, I'll fix it once I get home.

@alvinhochun
Copy link
Contributor

I'd prefer EL or EL_GR if you want, just to keep it like standard BCP 47 language tags (with dash replaced by underscore). You can see some other translations already follow this convention (JA_JP, NL_BE, SR_CYRL, SR_LATN, YUE_HK, ZH_CN, ZH_TW).

@Devnol
change translation filename to EL
8d9cbab 
Signed-off-by: Devnol <pgkoutsoumanis@gmail.com>
@Ralim Ralim merged commit 882bd68 into Ralim:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvinhochun alvinhochun alvinhochun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Devnol @alvinhochun @Ralim